Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extension inference to use subset constraints #919

Open
Tracked by #426
croyzor opened this issue Apr 8, 2024 · 0 comments
Open
Tracked by #426

Update extension inference to use subset constraints #919

croyzor opened this issue Apr 8, 2024 · 0 comments

Comments

@croyzor
Copy link
Contributor

croyzor commented Apr 8, 2024

Reference: extension reredux

The current unification system for extension inference uses equality constraints between metavariables. We allow target ports to have a greater set of extension requirements than the source ports that are wired to them, and we represent this by adding Lift nodes to those wires.

We've decided that these Lift nodes aren't worth the effort, so we should switch to representing our constraints directly as subsets rather than equality. I.e. we create a constraint saying that the requirements of a node are less than or equal to another node.

Replace the current version of the extension inference unification algorithm with the redux version which instead has constraints standing for subsets. We should then be able to delete lift nodes entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant