Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep copy: add native fallbacks for objects in js/py #47

Closed
kMutagene opened this issue Jan 3, 2025 · 1 comment · Fixed by #46
Closed

Deep copy: add native fallbacks for objects in js/py #47

kMutagene opened this issue Jan 3, 2025 · 1 comment · Fixed by #46

Comments

@kMutagene
Copy link
Member

Dictionary type matches are not transpiled, so we loose the case where we have objects at hand. this needs a proper native fallback
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Jan 3, 2025
@kMutagene
Copy link
Member Author

For reference, it seems like Dictionaries are transpiled as Map in js, and as dict in py.

See repl

I think this typecheck should be possible to implement in fable directly, but for now a workaround that checks instanceof Map in JS or isinstance dict in py.

@kMutagene kMutagene linked a pull request Jan 3, 2025 that will close this issue
Deep copy improvements #46
Merged
@kMutagene kMutagene moved this to In progress in ARCStack Jan 10, 2025
@kMutagene kMutagene removed the Status: Needs Triage This item is up for investigation. label Jan 10, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in ARCStack Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deep copy improvements CSBiology/DynamicObj
1 participant
@kMutagene