Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support any user identifying attribute in APIs #2772

Closed
1 task done
Macroz opened this issue Nov 2, 2021 · 1 comment · Fixed by #2858
Closed
1 task done

Support any user identifying attribute in APIs #2772

Macroz opened this issue Nov 2, 2021 · 1 comment · Fixed by #2858
Assignees

Comments

@Macroz
Copy link
Collaborator

Macroz commented Nov 2, 2021

Since userid should be an opaque internal id, we should support specifying any of the external user identifying attributes from :oidc-userid-attributes in the APIs where a :userid is currently expected.

  • change APIs to search for the user from one of :userid or :oidc-userid-attributes. First one will be used.

See https://github.com/CSCfi/rems/blob/master/docs/architecture/014-userids.md and particularly https://github.com/CSCfi/rems/blob/master/docs/architecture/014-userids.md#login

@Macroz
Copy link
Collaborator Author

Macroz commented Mar 21, 2022

There were three cases:

  1. x-rems-user-id which is handled in the middleware
  2. application commands, which have a Schema, and the command is patched in handle-command
  3. blacklist API, which can receive a userid as query parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants