Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config is not able to be overridden #2917

Closed
Macroz opened this issue Apr 19, 2022 · 1 comment
Closed

Config is not able to be overridden #2917

Macroz opened this issue Apr 19, 2022 · 1 comment
Assignees
@Macroz
Labels
BUG

Comments

@Macroz
Copy link
Collaborator

Macroz commented Apr 19, 2022

Config can't be overridden from system properties or the environment unless the key is present in the config file. This is a feature of cprop. We can fix it by manually merging all the props and env to the config. This should be mostly harmless, but in theory some key from e.g. the env could unintentionally override something.

See #2895 (comment)_
@Macroz Macroz added the BUG label Apr 19, 2022
@Macroz Macroz self-assigned this Apr 19, 2022
@Macroz
Copy link
Collaborator Author

Macroz commented Apr 27, 2022

Fixed by #2918

@Macroz Macroz closed this as completed Apr 27, 2022
@Macroz Macroz mentioned this issue May 16, 2022
Closed
@meericsc meericsc moved this to Accepted in REMS Task Board May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Macroz Macroz

Labels
BUG
Projects
REMS Task Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Macroz