Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**General contributions** #56

Open
spirosmaggioros opened this issue Jul 1, 2024 · 5 comments
Open

**General contributions** #56

spirosmaggioros opened this issue Jul 1, 2024 · 5 comments
Labels
algorithms bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers graph Related to graph class and/or functions for graphs help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested queue stack Tree Related to tree classes and/or functions for trees unit_tests visualization Related to visualization issues

Comments

@spirosmaggioros
Copy link
Member

Please be free to contribute whatever you think is useful. Don't only feel the need to contribute if there are issues open :)

@spirosmaggioros spirosmaggioros added algorithms bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers graph Related to graph class and/or functions for graphs help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested queue stack Tree Related to tree classes and/or functions for trees unit_tests visualization Related to visualization issues labels Jul 1, 2024
@aveldan
Copy link
Contributor

aveldan commented Jul 2, 2024

I was thinking of implementing a level-order traversal for the tree, I see it's not done yet. If that is okay I can start working on it.

@spirosmaggioros
Copy link
Member Author

Yes you can do that, i had one for every tree, but i deleted it because it's not a known algorithm, it's just something we do to solve problems. But yes, you can implement one for every tree header class and then i will create an ostream operator to print the trees using the level order traversal.

@aveldan
Copy link
Contributor

aveldan commented Jul 8, 2024

I was thinking of implementing Red Black tree, if no one is working on this right now. I can raise an issue and work on it. That include the tree implementation, visualization, tests and examples.

@spirosmaggioros
Copy link
Member Author

If you see, i lately added a 2-3-4 class and after that i was going to add a red black tree class as it's the only basic tree structure that is missing, though it has a very difficult implementation. I believe it's the second most difficult structure i've ever implemented, but yes, you can do that, but then i have to check it a lot myself to be sure. You'll save me a lot of time by adding it yourself if you think you can!

@aveldan
Copy link
Contributor

aveldan commented Jul 8, 2024

I know the concept but have never implemented it in a full scale like this, but yeah I am up for the challenge.
I will put in a issue, please assign it to me. I will work on it this week.

but then i have to check it a lot myself to be sure

Yes sure, that is what I expect.

You'll save me a lot of time by adding it yourself if you think you can!

Happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithms bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers graph Related to graph class and/or functions for graphs help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested queue stack Tree Related to tree classes and/or functions for trees unit_tests visualization Related to visualization issues
Projects
None yet
Development

No branches or pull requests

2 participants