Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization generator missing from tree.h header #60

Closed
spirosmaggioros opened this issue Jul 4, 2024 · 4 comments
Closed

Visualization generator missing from tree.h header #60

spirosmaggioros opened this issue Jul 4, 2024 · 4 comments
Labels
enhancement New feature or request Tree Related to tree classes and/or functions for trees visualization Related to visualization issues

Comments

@spirosmaggioros
Copy link
Member

the simple tree(tree.h header) was lately added and lacks a visualization generator function.
You can take the other tree headers as reference to create the generator function(to generate the string) and then to add a simple visualize() function in the class to perform the visualization using the returning string. The graphviz visualization function is ready at vizualization folder, you only need to implement the string generator.

@spirosmaggioros spirosmaggioros added enhancement New feature or request Tree Related to tree classes and/or functions for trees visualization Related to visualization issues labels Jul 4, 2024
@aveldan
Copy link
Contributor

aveldan commented Jul 4, 2024

I just reviewed the tree_visualization.h wouldn't the visualization gen for tree.h be also same as that of bst? I just made the tree.h one I can put in a pull request if you don't have it already.

@spirosmaggioros
Copy link
Member Author

Yes @aveldan, i mention it on my comment. It's nothing different, of course i can do it myself but i want contributors to do it just to get on groove with the repo and contribute more in the future.

@spirosmaggioros
Copy link
Member Author

@aveldan Do you have anything ready for this? I'm asking because you commented on this issue.

@spirosmaggioros
Copy link
Member Author

This is closed as of @aveldan 's #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Tree Related to tree classes and/or functions for trees visualization Related to visualization issues
Projects
None yet
Development

No branches or pull requests

2 participants