Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what to do with the end caps not aligning #14

Closed
argyleink opened this issue Nov 12, 2024 · 5 comments · Fixed by #55
Closed

what to do with the end caps not aligning #14

argyleink opened this issue Nov 12, 2024 · 5 comments · Fixed by #55

Comments

@argyleink
Copy link
Contributor

some people think it's glaringly bad, some dont notice, some will never see it at the tiny size they'll usually see it, other's might print it on a poster and be appalled. a couple questions:

  • if we solve it, then we cant just point to the Dinish font
  • if we solve it, how will we distribute the glyphs/shapes
@romainmenke
Copy link
Contributor

romainmenke commented Nov 12, 2024

Upstream issue?
Maybe the Dinish font creators are open to making such changes?

Edit: could also be a fork, it is open source :)

@mxdvl
Copy link
Contributor

mxdvl commented Nov 12, 2024

While visual adjustments make sense for a font, which is visually adjusted to work best at typical reading sizes, for a word mark that is often drawn at large “display” sizes, following a more rigorously geometric solution may be preferable.

Obviously in this case the canonical version would be the SVG and distributed that way.

@chriskirknielsen
Copy link

chriskirknielsen commented Nov 13, 2024

Agreeing with @mxdvl here — this was the one thing that bothered me using Dinish that I had to fix (though it is only following in the footsteps of original DIN fonts 😄).

While I think it's very cool to be able to recreate this in CSS with very little code, it does also mean it might look a little different based on the browser (font metrics are not always consistent across browsers) or if the fontr fails to load, and as such, two things come to mind:

  • it's okay to recreate the logo with the font as-is; it's a detail that can be ignored if you want to play around with it.
  • a "source of truth" SVG version would make sense: it is a logo after all, and as such I expect it to be used a lot more as SVG (or PNG) than an embedded HTML/CSS block of code, which means that the typeface changes can be baked into that "true" logo.

Providing SVG versions means that folks who would like to style it still can do so with CSS, meaning you could add, for example, the version number with a live piece of text using Dinish, but with an "imposed" set of paths for the CSS letters. Anyways I'm basically just repeating Max's point here!

If keeping it as editable text is essential, then I like the idea proposed by @romainmenke — it would be fairly easy to add either an alternate glyph, or a ligature, to correct this issue, but of course, that would require the proper CSS to be enabled so you still get the problem with very basic styling, so the fork might be the way to go in this case?

@rol4nd909
Copy link
Contributor

rol4nd909 commented Dec 23, 2024

@itsjavi or @argyleink can one of you update the figma file with the latest font?

https://github.com/playbeing/dinish/releases/tag/v4.003 the caps are aligned now.

I opend a pull request #55 with the new svg using the new font

@argyleink
Copy link
Contributor Author

@itsjavi or @argyleink can one of you update the figma file with the latest font?

https://github.com/playbeing/dinish/releases/tag/v4.003 the caps are aligned now.

I opend a pull request #55 with the new svg using the new font

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants