Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional exceptions not working #107

Open
AdrienVR opened this issue Feb 19, 2020 · 7 comments
Open

Optional exceptions not working #107

AdrienVR opened this issue Feb 19, 2020 · 7 comments
Labels

Comments

@AdrienVR
Copy link

Hello,

I'm using Exceptional v0.19.0 with R# 2019.2 (actually these only 2 issues prevent me to use it).
I have 2 issues with the Optional exceptions settings:
image
Enabling "Use predefined optional exceptions" is not saved (minor issue).
The big issue is that the user optional exceptions (which are saved) are not used, here I disable ArgumentException and ArgumentNullException, but I still have warnings with it:
image
Same if I set Always instead of InvocationOnly
Am I doing something wrong or is there a bug?

Anyway this plugin is a great project and I would love to use it!
Cheers!

@ManticSic
Copy link
Collaborator

Thanks for your feedback.

Saving the settings should now work since Januar 2020, see #75.
The fix should be available in 0.22.0 release.

To install the latest version, you have to update your R# to 2019.3.x.

When I have some time, I will check if the optional exceptions feature still not work, as far as I know it should work in the latest version.

@AdrienVR
Copy link
Author

Tested today with Exceptional v0.22.0 (Nightly) with R# 2019.3 and I still have the exact same issues.
The issue you linked is different, indeed global settings of Exceptional are saved (that's why the user optional exceptions are well saved) but it seems there is an issue particularly for Use predefined optional exceptions

@AdrienVR
Copy link
Author

I just discovered that Method and property visibility settings are not saved. To be precise I do the tests for the team-shared settings, don't know if it is related to this.
image
image

@ManticSic
Copy link
Collaborator

Hm... For me it works, even with team-shared settings.

Do you use a layer?
Which VS version do you use?

@AdrienVR
Copy link
Author

These are all my layers:
image
I'm using VS2017 but I tested with VS2019 today and have the same issue.

@AdrienVR
Copy link
Author

These are all my layers:
image
I'm using VS2017 but I tested with VS2019 today and have the same issue.

Here is a video:
https://youtu.be/Ci9tlwZUjzE

@ManticSic
Copy link
Collaborator

Hey, thanks for the video. that was helpful!
I tthink I know the problem and I will try to fix it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants