Automatically resize grid according to the model size

[Peque]

Right now the grid is defined with its size and number of divisions.

While this is fine and should be kept as a possibility, the default should set a grid with a size double the longest dimension of the displayed model.

[garrlker]

I'd like to try my hand at this!

[Peque]

Great! 😊

[shimwell]

Perhaps it would also be nice to have the option to not include the grid at all

[Peque]

@shimwell Yeah! 👍

[shimwell]

Does this approach sound ok to you @Peque ?

make another variable called raw_gridless_html_template which is the same as raw_html_template but misses the parent.gridsize and griddivisions parts

then add an if statement to the run function and if gridsize and griddivisions are not specified in the user options then make use of the raw_gridless_html_template

[Peque]

@shimwell So I guess you are suggesting that, by default, no grid should be displayed (unless the user defines gridsize).

I think I would rather leave the default behavior as-is (i.e.: show a grid).

So, how could we disable the grid? Instead of adding a new parameter, I'd say gridsize=0 should disable the grid. Maybe an if in the main.js:init() function to check if gridsize is greater than 0?

[shimwell]

That sounds better

[shimwell]

Changing this

https://github.com/Peque/sphinxcadquery/blob/917dedfe0dd7a4aae092922b1a3c0f323c099dc4/sphinxcadquery/sphinxcadquerystatic/main.js#L143

to this appears to work for me

        if ( gsize > 0 ){
            var grid = new TranslucentGrid( gsize, gdivs, 0x888888, 0xdddddd, 0.6, );
        }

[Peque]

@shimwell What about the references to grid just bellow? Don't they throw an error?

https://github.com/Peque/sphinxcadquery/blob/917dedfe0dd7a4aae092922b1a3c0f323c099dc4/sphinxcadquery/sphinxcadquerystatic/main.js#L145-L147

Maybe put all those lines inside the if clause? (from the var grid declaration to the scene.add(grid) call).

[shimwell]

Yep you are right. I was just testing it worked with out the grid

I can make a PR for your consideration

[shimwell]

Just to get this issue back on track I wanted to mention that Cadquery has a bounding box that can be used to find the shape size in x,y,z https://cadquery.readthedocs.io/en/latest/classreference.html?highlight=boundingbox#cadquery.Shape.BoundingBox