Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information on derivative calculation to science section #169

Closed
ischoegl opened this issue Jan 13, 2022 · 1 comment · Fixed by Cantera/cantera#1563
Closed

Add information on derivative calculation to science section #169

ischoegl opened this issue Jan 13, 2022 · 1 comment · Fixed by Cantera/cantera#1563
Assignees
Labels
documentation-update An update is needed to the documentation

Comments

@ischoegl
Copy link
Member

ischoegl commented Jan 13, 2022

The PR Cantera/cantera#1089 introduces the capability to calculate derivatives of reaction rate expressions. As noted there:

The Jacobian implemented in this PR is strictly for the source term; it does not consider constraints posed by the EoS, which can only be handled once additional assumptions inherent to a specific model are known (e.g. constant pressure / volume etc.). As such, results are different from a strictly numerical Jacobian, which includes additional terms due to the EoS closure. Note that these terms are implemented in the test suite where numerical / semi-analytical jacobians are compared.

Per @speth's review comment:

[...] it makes sense to me that these derivatives are calculated with other quantities held constant as the equations are written, independent of whether that satisfies the equation of state or the sum(X) = 1 constraint. I think it would be very useful to provide a bit of guidance to users on this point, that is, noting that they can calculate other derivatives using the chain rule and whatever equation they need to satisfy, and maybe providing an example of how to calculate a Jacobian at constant volume or at constant pressure.

Due to the number of access function introduced in various API's, it would make sense to collect corresponding information in the Science section of the website.

@ischoegl
Copy link
Member Author

In view of Cantera/enhancements#178, detailed documentation is added to Doxygen directly (see PR Cantera/cantera#1563). This approach is in line with past practice of Cantera documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-update An update is needed to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants