-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check reactions for balance of surface sites #412
Comments
Fundamentally, does creation of a reaction even check for stoichiometry? I mean, I can execute this line in the dev-version with Py2.7 without any error:
Not that there is an imbalance of H on both sides |
Ok, Cantera does when a solution object is created... |
I think the reason the first one is valid is because there is no atomic composition information associated with the species in a |
Yup, but why do this much later in |
As Bryan says, when you create a Reaction object, all it knows is the name of the species, not its composition, or any other data that is contained in a Species object. So these checks are only possible at the point where the Reaction is added to a Kinetics object.
|
Expected Behavior
A reaction such as:
where
CH4(s)
is a surface species and all others are gas phase should be identified as problematic because it does not balance the number of surface sites.Actual Behavior
Incorrect rates are computed in reactor calculations -- if the only surface species are
CH4(s)
and a species representing open sites, then the coverages will not change.Proposed resolution
When validating surface reactions, require that
sum(species.size)
over the surface species is the same for the reactants and products.Originally reported at https://groups.google.com/forum/#!topic/cantera-users/wlww4-RUC_E
The text was updated successfully, but these errors were encountered: