Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BLAS/LAPACK by default if installed #144

Closed
ischoegl opened this issue Mar 27, 2022 · 0 comments · Fixed by Cantera/cantera#1316
Closed

Use BLAS/LAPACK by default if installed #144

ischoegl opened this issue Mar 27, 2022 · 0 comments · Fixed by Cantera/cantera#1316
Labels
feature-request New feature request

Comments

@ischoegl
Copy link
Member

ischoegl commented Mar 27, 2022

Abstract

While many 'system'-installed packages are detected and used by default (e.g. Eigen, fmt, sundials, yaml-cpp), the same is not true for BLAS and LAPACK. Instead, it does require the blas_lapack_libs flag (as expected, there currently is no system_blas_lapack option).

While there are some issues related to incompatible versions packaged with MATLAB, it would make sense to use BLAS and LAPACK by default otherwise (instead of Eigen's linear algebra support). Based on communication with @speth there are couple of caveats to consider:

[...] there are a number of special cases that you would want handle. One is that one of the best BLAS/LAPACK implementations to link to would be the MKL if it’s present. The other is that if you’re trying to autodetect, you probably want to try figuring out if it’s a version that uses an 8-byte index type or not (which is the Matlab issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant