Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbsintheClient.attach/2 causes dialyzer errors with req 0.5.x #18

Open
fastjames opened this issue Jun 26, 2024 · 1 comment
Open

AbsintheClient.attach/2 causes dialyzer errors with req 0.5.x #18

fastjames opened this issue Jun 26, 2024 · 1 comment

Comments

@fastjames
Copy link
Contributor

Since I am the one who submitted the recent change allowing AbsintheClient's req dependency to go to 0.5.x, I need to follow that up with a problem I discovered while using the latest version of AbsintheClient.

I initially updated AbsintheClient without changing my version of req, so the problem wasn't immediately apparent. Today when I tried to update req, I ran into some unexpected dialyzer errors that I narrowed down to the function that calls AbsintheClient.attach(). The error is Function some_func/0 has no local return for the calling function.

In order to narrow the scope of investigation, I created a blank elixir application and added enough code to cause the same behavior I'm seeing in my application. You can view it at

https://github.com/fastjames/hello_absinthe_client

Cloning the repo, then running mix deps.get && mix dialyzer should produce the dialyzer errors.

My hope is that I'm making a basic error in how I set up req and/or AbsintheClient.

@fastjames
Copy link
Contributor Author

Req provides a changelog entry for 0.5.0 (https://github.com/wojtekmach/req/blob/main/CHANGELOG.md#v050-2024-05-28) but I did not see anything in it that appeared to be relevant to the problem described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant