Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

make depends fails trying to copy include files #22

Closed
2 tasks done
low-batt opened this issue Jan 18, 2022 · 9 comments
Closed
2 tasks done

make depends fails trying to copy include files #22

low-batt opened this issue Jan 18, 2022 · 9 comments

Comments

@low-batt
Copy link
Collaborator

System and IINA version:

  • macOS 12.1
  • IINA 1.2.0

Expected behavior:
make depends is successful

Actual behavior:

make depends fails at cp command:

rm -rf deps/include/mpv deps/include/ffmpeg
bash -c 'cp -r "/opt/homebrew/opt/ffmpeg-iina/include/"* deps/include/'
usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvXc] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-apvXc] source_file ... target_directory
make: *** [depends] Error 64

Steps to reproduce:
Run "make depends"

  • MPV does not have this problem.
  • Official IINA does not have this problem.

How often does this happen?
Everytime

@CarterLi
Copy link
Owner

Yes I'm confused by this strange CI issue

cp -r "/opt/homebrew/opt/ffmpeg-iina/include/"* deps/include/ doesn't seem to be problematic, and works well on my mac

@CarterLi
Copy link
Owner

I'm testing CI with some changes, hence lots of force-push

@low-batt
Copy link
Collaborator Author

Is that why my commit just disappeared? I had just pushed a fix for iina#3211. I thought it made it in as I remember seeing 100 commits ahead of IINA, but now back to 99. I'll hold off until you give the ok that you have CI working and it is safe to push.

@low-batt
Copy link
Collaborator Author

Do you have some special upgraded cp on your Mac? Normally you use captial -R for recursive with cp.

@low-batt
Copy link
Collaborator Author

The other build issues I had with make depends seemed to have to do with having already built mpv before. brew wanted reinstall to be used instead of install. Oh, and I'm missing the "create-dmg" app.

@CarterLi
Copy link
Owner

Do you have some special upgraded cp on your Mac? Normally you use captial -R for recursive with cp.

What the...

I use gnu-coreutils and never know that

@low-batt
Copy link
Collaborator Author

Ah. I see cp -r is a gnu-coreutils thing. Also "shell" wasn't recognized for me.

@CarterLi
Copy link
Owner

However cp -r used to work well

I think I know what the real problem is

@CarterLi
Copy link
Owner

CI is fine now. Closing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants