Fix for collation errors when importing catallog tables #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #393 by avoiding collation options. The affected function is only used from diagnostics, and aside from `pg_extension` only meant to import other catallog tables for internal diagnostics (`pg_catalog` and `pg_settings`) so it shall be pretty safe.
|
Can you explain why this is needed here and not in the other places where |
|
Because of default collations, checks in FDW's, and catallog tables using |
|
I'm sorry but I don't understand it. What about a foreign table that uses NAME as one of the column, is that different? How? |
|
I suspect it is not different at all, just less common |
With this, Josema could keep testing, listing remote tables without otherwise ERROR in DB and 500 error in RoR.
Algunenano
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #393 by avoiding collation options. The affected function
is only used from diagnostics, and aside from
pg_extensiononlymeant to import other catallog tables for internal
diagnostics (
pg_catalogandpg_settings) so it shall be prettysafe.