Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO] Feature flag for instant licensing #15254

Closed
gonzaloriestra opened this issue Nov 21, 2019 · 4 comments
Closed

[DO] Feature flag for instant licensing #15254

gonzaloriestra opened this issue Nov 21, 2019 · 4 comments

Comments

@gonzaloriestra
Copy link
Contributor

gonzaloriestra commented Nov 21, 2019

We are now checking if the do-licensing feature flag is enabled for subscription operations, but we should change it to do-instant-licensing and:

  • Always allow getting subscription info and doing normal license.
  • Do normal license when the estimated_delivery_days is 0 but it's not enabled.
  • Add the feature flag state in do/token and more information:
{
    access_token: 'xxx',
    bq_public_project: 'xxx',
    gcp_execution_project: 'xxx',
    bq_project: 'carto-do-customers',
    bq_dataset: 'xxx',
    gcs_bucket: 'xxx',
    instant_licensing: false
}
@alasarr
Copy link
Contributor

alasarr commented Nov 21, 2019

Let's do it through a /api/v4/me. Let add there two flag:

"data_observatory": { "instant_licensing": true}

Feel free to change the ☝️ format is necessary

@gonzaloriestra
Copy link
Contributor Author

Besides instant_licensing, we will need to send more info to decouple from CF and make DO more usable from other places:

  • Service account project (for the billing)
  • BigQuery project + dataset
  • GCS project + bucket

As this information is related to the token, because it's required to be able to use it, @oleurud and I think that it would make sense to include it in the do/token endpoint.

That way, we would avoid an extra call from CF (or from any other place where people want to use the DO token). Also, we would keep the DO stuff more separated from Carto, in case we want to extract the DO API someday.

What do you think @alasarr @alrocar?

@alasarr
Copy link
Contributor

alasarr commented Dec 3, 2019

I prefer the /api/v4/me but not a strong opinion, go for it if you want.

@gonzaloriestra gonzaloriestra changed the title [DO] Feature flag for speed licensing [DO] Feature flag for instant licensing Dec 4, 2019
@Jesus89
Copy link
Member

Jesus89 commented Dec 20, 2019

Closed via #15315

@Jesus89 Jesus89 closed this as completed Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants