Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO: catalog and enrichment namespace #1018

Closed
simon-contreras-deel opened this issue Sep 24, 2019 · 8 comments
Closed

DO: catalog and enrichment namespace #1018

simon-contreras-deel opened this issue Sep 24, 2019 · 8 comments
Assignees

Comments

@simon-contreras-deel
Copy link
Contributor

simon-contreras-deel commented Sep 24, 2019

Right now, under cartoframes.data we have

  • observatory folder wit the catalog things
  • enrichment folder with the enrichment things

I think we should:

  • create cartoframes.data.observatory.catalog with all the catalog stuff
  • create cartoframes.data.observatory.enrichment with all the enrichment stuff
  • in the cartoframes.data __ init __ I would add:
catalog
enrichment_points
enrichment_polygons

How do you see it? @esloho @alejandrohall @alrocar

@alrocar
Copy link
Contributor

alrocar commented Sep 24, 2019

LGTM!

@simon-contreras-deel
Copy link
Contributor Author

I think we need to tackle this one sooner than later because if you do it at the end we could have some problems with the references in docs or examples

@alrocar
Copy link
Contributor

alrocar commented Oct 2, 2019

OK, let's focus on the download feature and we can priorize this next. I'm moving to the this week column.

@alrocar
Copy link
Contributor

alrocar commented Oct 8, 2019

Let's use this issue to rename de Dataset class in the catalog to anything else to avoid collisions with the data Dataset.

Name TBD yet.

@simon-contreras-deel
Copy link
Contributor Author

simon-contreras-deel commented Oct 8, 2019

Also to unify _WORKING_PROJECT constant in one place (the __ init __ file of observatory?)

@cmongut
Copy link
Contributor

cmongut commented Oct 8, 2019

We are going to maintain the observatory concept for now so let's move the enrichment part inside 🙂

@Jesus89 Jesus89 self-assigned this Oct 21, 2019
@Jesus89
Copy link
Member

Jesus89 commented Oct 23, 2019

Directory tree:

cartoframes/data/
├── clients
├── dataset
├── observatory
│   ├── catalog
│   └── enrichment
└── services

API:

from cartoframes.data import Dataset
from cartoframes.data.clients import SQLClient, DataObsClient
from cartoframes.data.services import Geocoding, Isolines
from cartoframes.data.observatory import Catalog, Category, Country, CatalogDataset \
    Geography, Provider, Variable, enrich_points, enrich_polygons

Question: Do we want to expose everything at the data level?

@Jesus89
Copy link
Member

Jesus89 commented Oct 24, 2019

Closed in #1119

@Jesus89 Jesus89 closed this as completed Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants