-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO: catalog and enrichment namespace #1018
Comments
LGTM! |
I think we need to tackle this one sooner than later because if you do it at the end we could have some problems with the references in docs or examples |
OK, let's focus on the download feature and we can priorize this next. I'm moving to the this week column. |
Let's use this issue to rename de Name TBD yet. |
Also to unify |
We are going to maintain the observatory concept for now so let's move the enrichment part inside 🙂 |
Directory tree:
API: from cartoframes.data import Dataset
from cartoframes.data.clients import SQLClient, DataObsClient
from cartoframes.data.services import Geocoding, Isolines
from cartoframes.data.observatory import Catalog, Category, Country, CatalogDataset \
Geography, Provider, Variable, enrich_points, enrich_polygons Question: Do we want to expose everything at the |
Closed in #1119 |
Right now, under cartoframes.data we have
observatory
folder wit the catalog thingsenrichment
folder with the enrichment thingsI think we should:
cartoframes.data.observatory.catalog
with all the catalog stuffcartoframes.data.observatory.enrichment
with all the enrichment stuffcartoframes.data
__ init __ I would add:How do you see it? @esloho @alejandrohall @alrocar
The text was updated successfully, but these errors were encountered: