Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_obs_client examples and fixes #1319

Closed
alrocar opened this issue Dec 4, 2019 · 1 comment · Fixed by #1327
Closed

data_obs_client examples and fixes #1319

alrocar opened this issue Dec 4, 2019 · 1 comment · Fixed by #1327
Assignees
Labels

Comments

@alrocar
Copy link
Contributor

alrocar commented Dec 4, 2019

While running the darta_obs_client examples I found out this error:

TypeError                                 Traceback (most recent call last)
<ipython-input-4-26a14e86748a> in <module>
----> 1 es_boundaries = do.boundaries(region='Spain')
      2 es_boundaries.dataframe[['geom_name', 'geom_id']]

~/Documents/dev/cartoframes/cartoframes/data/clients/data_obs_client.py in boundaries(self, boundary, region, decode_geom, timespan, include_nonclipped)
    198                     timespan=utils.pgquote(timespan),
    199                     filters='WHERE {}'.format(filters) if filters else '')
--> 200             return self._fetch(query, decode_geom=True)
    201 
    202         query = utils.minify_sql((

TypeError: _fetch() got an unexpected keyword argument 'decode_geom'

cc. @Jesus89 for triage

@alrocar alrocar added this to the [1.0rc1] Stabilization milestone Dec 4, 2019
@Jesus89 Jesus89 added the bug label Dec 4, 2019
@Jesus89
Copy link
Member

Jesus89 commented Dec 4, 2019

This is a quick (and necessary) fix. We can review also the DO v1 e2e tests which are not up to date.

@Jesus89 Jesus89 self-assigned this Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants