Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper methods - Size continuous #653

Closed
2 tasks done
makella opened this issue May 7, 2019 · 3 comments
Closed
2 tasks done

Helper methods - Size continuous #653

makella opened this issue May 7, 2019 · 3 comments
Assignees

Comments

@makella
Copy link
Contributor

makella commented May 7, 2019

For

  • points
  • lines
@makella
Copy link
Contributor Author

makella commented Jun 12, 2019

@Jesus89 as a first go, let's try this for size continuous:

Points:

width: ramp(linear(sqrt($number), sqrt(globalMin($number)), sqrt(globalMax($number))), [0.2*zoom(), 8*zoom()])

Lines

WIP!

To discuss tomorrow:

  • Now that we are using Positron, there are some slight modifications that I want to make to the basic symbology to account for the lighter basemap. I tried to do one of them, but the test failed so I reverted back
  • related, I want to test out some different point colors which may likely result in a change for the "basic" point color from red to something else. What we'll want to make sure is that we pick a color that will work well on its own for basic points, together with the default color for lines and polygons as well as with all other helper method layers. Basically, I'll need to do some testing with all of this! I figure that once we get these size helpers in, I can modify the styles as I'm testing in CF.
  • the ordering of symbols width() isn't the best option (will show you why) would be better to order by attribute, but since that functionality isn't there yet, I am not including it also even width isn't available to order by with lines. Will show you an example of how helpful this would be (for us to think about for the future).
  • would like to add opacity once I figure out the color and I think for both

@Jesus89 Jesus89 self-assigned this Jun 12, 2019
@makella
Copy link
Contributor Author

makella commented Jun 12, 2019

As discussed, for now, we aren't going to use zoom() we will look at that for a future release where we can have the legends be dynamic as well. Also, we will give the users the ability with our implementation to modify the size ranges in addition to the color of features.

@Jesus89
Copy link
Member

Jesus89 commented Jun 12, 2019

Done in #770

@Jesus89 Jesus89 closed this as completed Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants