New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset().upload() does not work with default credentials #913

Closed

andy-esch opened this issue Aug 14, 2019 · 0 comments · Fixed by #969

Assignees

Labels

bug

Contributor

andy-esch commented Aug 14, 2019

Code to reproduce:

from cartoframes.auth import set_default_credentials, Credentials

creds = Credentials(
    'eschbacher',
    'abc123'
)
set_default_credentials(creds)

ds = Dataset(df)
# this throws an error
# ValueError: You should provide a table_name and credentials to upload data. 
ds.upload(table_name='test_upload')

# this works
ds.upload(table_name='test_upload', credentials=creds)

simon-contreras-deel self-assigned this

simon-contreras-deel added the bug label

simon-contreras-deel mentioned this issue

in upload, if creds are None, use default creds #969

Merged

simon-contreras-deel closed this as completed in #969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment