-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the last step is not rendered when the animation is playing #60
Comments
@javisantana literally just started looking at this, so dismiss if it's nothing to do with the issue, but on the _tick function of Animator... if(this.step() >= this.options.steps) {
this._time = 0;
} Shouldn't it be |
@fdansv probably that's the issue |
As far as I can see, the last step is actually rendered, even though it instantly disappears because we're assuming the general use case for Torque is loads of points where the fact that the last one is only shown for a few millis is irrelevant. However, on a timeline where every point is important for the visualisation there either should be an optional timeout upon reaching the end to allow the user to actually see the last point, or the user should disable looping. |
there is something I don't get here, in the original report we had: torque-frame-count = 51 then, in the timeline, torque renders from 0 to 51 (frame 51 is rendered for a few milliseconds and you mention), that makes 52 steps. Why? |
looks like when the animation reach the last step it just jump to the step 0 without rendering the last frame
The text was updated successfully, but these errors were encountered: