Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the last step is not rendered when the animation is playing #60

Closed
javisantana opened this issue Dec 3, 2014 · 4 comments
Closed

the last step is not rendered when the animation is playing #60

javisantana opened this issue Dec 3, 2014 · 4 comments

Comments

@javisantana
Copy link
Contributor

looks like when the animation reach the last step it just jump to the step 0 without rendering the last frame

@fdansv
Copy link
Contributor

fdansv commented Dec 9, 2014

@javisantana literally just started looking at this, so dismiss if it's nothing to do with the issue, but on the _tick function of Animator...

if(this.step() >= this.options.steps) {
    this._time = 0;
}

Shouldn't it be > instead of >= so that it doesn't skip the last step?

@javisantana
Copy link
Contributor Author

@fdansv probably that's the issue

@fdansv
Copy link
Contributor

fdansv commented Dec 10, 2014

As far as I can see, the last step is actually rendered, even though it instantly disappears because we're assuming the general use case for Torque is loads of points where the fact that the last one is only shown for a few millis is irrelevant.

However, on a timeline where every point is important for the visualisation there either should be an optional timeout upon reaching the end to allow the user to actually see the last point, or the user should disable looping.

@javisantana
Copy link
Contributor Author

there is something I don't get here, in the original report we had:

torque-frame-count = 51
torque-time-attribute = "week" (being week in range [1, 52])
so torque should report 52 - 1 + 1 steps => 51

then, in the timeline, torque renders from 0 to 51 (frame 51 is rendered for a few milliseconds and you mention), that makes 52 steps. Why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants