Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the ThreadStatic. #223

Merged
merged 1 commit into from
May 11, 2019
Merged

Removed the ThreadStatic. #223

merged 1 commit into from
May 11, 2019

Conversation

ymh199478
Copy link
Contributor

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? No
Removed Yes
Tests pass? Yes
Doc pr? No

The ThreadStatic class has been removed because the methods provided by this class can cause some potential problems, such as:

When the developer uses ThreadStatic.Buffer, the code of the framework also uses buffer, which will cause some hidden problems.

Since we were not able to determine the developer’s intent, we removed this feature.

@ymh199478 ymh199478 mentioned this pull request May 11, 2019
55 tasks
@ymh199478 ymh199478 merged commit 6a9bdda into master May 11, 2019
@ymh199478 ymh199478 deleted the removed/free-thread-static branch May 11, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant