Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Str.Encoding #245

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Removed Str.Encoding #245

merged 1 commit into from
Jun 25, 2019

Conversation

ymh199478
Copy link
Contributor

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? Yes
Removed No
Tests pass? Yes
Doc pr? No

This commit removes the definition of Str.Encoding because we don't want to control global Encoding through a static object.

@ymh199478 ymh199478 mentioned this pull request Jun 25, 2019
55 tasks
@codecov-io
Copy link

codecov-io commented Jun 25, 2019

Codecov Report

Merging #245 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   97.23%   97.23%   -0.01%     
==========================================
  Files          36       36              
  Lines        2461     2460       -1     
==========================================
- Hits         2393     2392       -1     
  Misses         68       68
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 99.45% <ø> (-0.01%) ⬇️
src/CatLib.Core/Support/Extension/ExtendString.cs 100% <100%> (ø) ⬆️
src/CatLib.Core/Support/Extension/ExtendStream.cs 89.74% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0ec90...7afab24. Read the comment docs.

@ymh199478 ymh199478 merged commit 9ad07ff into master Jun 25, 2019
@ymh199478 ymh199478 deleted the removed/free-encoding branch June 25, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants