Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors Guard classes. #250

Merged
merged 1 commit into from
Jun 30, 2019
Merged

Refactors Guard classes. #250

merged 1 commit into from
Jun 30, 2019

Conversation

ymh199478
Copy link
Contributor

Q A
Branch? v2.0(master)
Bug fix? No
New feature? Yes
Deprecations? No
Internal Changed? No
Removed No
Tests pass? Yes
Doc pr? No

This commit refactors the Guard class, adds messages when throwing exceptions, and internal exceptions, while allowing developers to customize exception factories to generate exceptions.

@ymh199478 ymh199478 changed the title Rebuild Guard classes. Refactors Guard classes. Jun 30, 2019
@codecov-io
Copy link

codecov-io commented Jun 30, 2019

Codecov Report

Merging #250 into master will decrease coverage by 0.09%.
The diff coverage is 90.69%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #250     +/-   ##
=========================================
- Coverage   97.54%   97.44%   -0.1%     
=========================================
  Files          35       35             
  Lines        2445     2467     +22     
=========================================
+ Hits         2385     2404     +19     
- Misses         60       63      +3
Impacted Files Coverage Δ
src/CatLib.Core/Container/BindData.cs 100% <100%> (ø) ⬆️
src/CatLib.Core/Container/Container.cs 99.67% <100%> (ø) ⬆️
src/CatLib.Core/Support/Guard.cs 82.5% <87.87%> (-1.72%) ⬇️
src/CatLib.Core/Support/Stream/PipelineStream.cs 76.31% <0%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 349e70d...2b3c718. Read the comment docs.

@ymh199478 ymh199478 mentioned this pull request Jun 30, 2019
55 tasks
@ymh199478 ymh199478 merged commit d6074d2 into master Jun 30, 2019
@ymh199478 ymh199478 deleted the added/free-guard branch July 23, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants