-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minimum Free Disk Space setting not working (fixes #277) #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catfriend1
changed the title
20190124 fix issue277
Fix minimum Free Disk Space setting not working (fixes #277)
Jan 26, 2019
See gson glitch: google/gson#1290 google/gson#968
This reverts commit d358862.
This reverts commit ca3931b.
Dev Note: It generally works like this but when syncthing core is running, gson deserializes "longer numbers" saved by syncthing core in scientific format from "xxxE+8" to "xxyE8" and on posting the number back the gson serializing posts "xxy" instead of "xxx" so the value is wrong afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Fix minimum Free Disk Space setting not working (fixes #277)
Testing:
Verified working on AVD 7.0 and AVD 9.x at commit 03ea393 .