Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimum Free Disk Space setting not working (fixes #277) #278

Merged
merged 35 commits into from
Jan 27, 2019

Conversation

Catfriend1
Copy link
Owner

@Catfriend1 Catfriend1 commented Jan 26, 2019

Purpose:
Fix minimum Free Disk Space setting not working (fixes #277)

Testing:
Verified working on AVD 7.0 and AVD 9.x at commit 03ea393 .

@Catfriend1 Catfriend1 added the bug label Jan 26, 2019
@Catfriend1 Catfriend1 added this to the 1.0.1 milestone Jan 26, 2019
@Catfriend1 Catfriend1 self-assigned this Jan 26, 2019
@Catfriend1 Catfriend1 changed the title 20190124 fix issue277 Fix minimum Free Disk Space setting not working (fixes #277) Jan 26, 2019
@Catfriend1
Copy link
Owner Author

Dev Note: It generally works like this but when syncthing core is running, gson deserializes "longer numbers" saved by syncthing core in scientific format from "xxxE+8" to "xxyE8" and on posting the number back the gson serializing posts "xxy" instead of "xxx" so the value is wrong afterwards.
Maybe Jackson can help here if we use it.

@Catfriend1 Catfriend1 merged commit 5911914 into master Jan 27, 2019
@Catfriend1 Catfriend1 deleted the 20190124-fixIssue277 branch January 27, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum Free Disk Space setting not working/respected?
1 participant