CATROID-1056 Fix wrong variable references after undo #4143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.catrob.at/browse/CATROID-1056
When loading the old values of the variables after an undo a deep copy of all the uservariables was restored. This leads to the problem that there are now two instances of the same uservariable (one in the uservariable list of the project and one that is actually stored within the bricks). In order to fix this after performing an undo the uservariables are not copied in a deep manner but just the values are restored (so that the references do not change).
Additionally changed the test
FormulaEditorUndoTest
to also check if the uservariable references stay the same after an undo.Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.