CATROID-1434 [HIGH-PRIORITY] Very high frequency ANR: catroid.ui.MainMenuActivity (server) is not responding

[danielzhang130]

Somewhat a non-definitive fix, as it does not address why the lock in XstreamSerializer cannot acquired. On the other hand, acquiring a lock is a IO operation so it should not run on main UI thread anyways.

https://jira.catrob.at/browse/IDE-72

Manual testing:

• replace loadSaveLock.lock() with Thread.sleep(15000)
• open main menu activity
• click + fab to add a project, follow dialog
• once in the project, exit with back button
• ANR dialog should show up

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

• Include the name of the Jira ticket in the PR’s title
• Include a summary of the changes plus the relevant context
• Choose the proper base branch (develop)
• Confirm that the changes follow the project’s coding guidelines
• Verify that the changes generate no compiler or linter warnings
• Perform a self-review of the changes
• Verify to commit no other files than the intentionally changed ones
• Include reasonable and readable tests verifying the added or changed behavior
  Ideas for automatic testing is welcomed
• Confirm that new and existing unit tests pass locally
• Check that the commits’ message style matches the project’s guideline
• Stick to the project’s gitflow workflow
• Verify that your changes do not have any conflicts with the base branch
• After the PR, verify that all CI checks have passed
• Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

[moberer]

Seems like a reasonable fix.

In my opinion, this is pretty much impossible to test, so I would accept it without automatic tests.

One thing that could be added is a comment to the coroutine start, in order to prevent accidental deletion by someone who does not know why it is there.

[KarlDerMaisbauer]

Looks fine, can be merged.

[danielzhang130]

Seems like a reasonable fix.

In my opinion, this is pretty much impossible to test, so I would accept it without automatic tests.

One thing that could be added is a comment to the coroutine start, in order to prevent accidental deletion by someone who does not know why it is there.

Added comment