IDE-79 .webp looks not shown on stage #4682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsebastian
force-pushed
the
IDE-79
branch
2 times, most recently
from
15d8e40 to
9a4d5f7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sebastiangollob
requested changes
Feb 3, 2023
catroid/src/androidTest/java/org/catrobat/catroid/test/common/LookDataTest.java
Outdated
Show resolved
Hide resolved
catroid/src/androidTest/java/org/catrobat/catroid/test/common/LookDataTest.java
Outdated
Show resolved
Hide resolved
catroid/src/androidTest/java/org/catrobat/catroid/test/common/LookDataTest.java
Show resolved
Hide resolved
catroid/src/androidTest/java/org/catrobat/catroid/test/common/LookDataTest.java
Show resolved
Hide resolved
devsebastian
force-pushed
the
IDE-79
branch
2 times, most recently
from
c296be8 to
1c3d22c
Compare
sebastiangollob
requested changes
Feb 3, 2023
| .perform(click()); | ||
| onView(withId(R.id.button_play)) | ||
| .perform(click()); | ||
| assertEquals(project.getUserVariable("color").getValue(), "#9a721c"); |
There was a problem hiding this comment.
This test fails in the pipeline
There was a problem hiding this comment.
checked and resolved the issue @sebastiangollob
devsebastian
force-pushed
the
IDE-79
branch
4 times, most recently
from
2ffbe9d to
bef6c10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.catrob.at/browse/IDE-79
.webp images https://en.wikipedia.org/wiki/WebP images are shown correctly in thumbs in the IDE and also correctly in Paintroid, but are rendered as empty looks on the stage when a project is executed. The looks are shown correctly after a minimal change was made using Paintroid, i.e., once the webp formatted image was converted to a png format.
Fix: convert looks in webp format to png format when they are imported.
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.