Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-558 Fix build with Catroid #4789

Merged
merged 1 commit into from
Apr 25, 2023
Merged

PAINTROID-558 Fix build with Catroid #4789

merged 1 commit into from
Apr 25, 2023

Conversation

mseiser
Copy link
Contributor

@mseiser mseiser commented Apr 25, 2023

https://jira.catrob.at/browse/PAINTROID-558

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

reichli
reichli approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@reichli reichli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

bengaal
bengaal approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@bengaal bengaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@bengaal bengaal merged commit 85848ae into develop Apr 25, 2023
@mseiser mseiser deleted the PAINTROID-558 branch May 2, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengaal bengaal bengaal approved these changes

@reichli reichli reichli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mseiser @reichli @bengaal @juliajulie95