Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The copy step should be idempotent if a previous playbook run failed #2

Open
bstinsonmhk opened this issue Mar 11, 2019 · 1 comment
Assignees

Comments

@bstinsonmhk
Copy link
Contributor

If a previous run of adhoc-sshd_sign_host_key.yml fails, and then the playbook is re-run, the files exist on the CA, but have not been copied yet. We should probably register a check from the target, and condition on that instead of checking if signing happened.

when: ssh_signing is changed

TASK [Ensuring we have needed .pub files on CA host] ********************************
ok: [mbox.rdu2.centos.org -> certbot.rdu2.centos.org]

TASK [Signing host pub keys with CA key] ********************************************
skipping: [mbox.rdu2.centos.org]

TASK [Find new -cert.pub files on CA host] ******************************************
skipping: [mbox.rdu2.centos.org]

TASK [Copy -cert.pub files back from CA host] ***************************************
fatal: [mbox.rdu2.centos.org]: FAILED! => {"msg": "'None' has no attribute 'path'"}

PLAY RECAP **************************************************************************
mbox.rdu2.centos.org       : ok=5    changed=0    unreachable=0    failed=1
@bstinsonmhk bstinsonmhk self-assigned this Mar 11, 2019
@harshu1470
Copy link

Can I work on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants