From 8d2e24bc35d611a620d3a0ae75e2e8eb3136e330 Mon Sep 17 00:00:00 2001 From: Futa Ikeda Date: Wed, 20 Nov 2024 14:51:04 -0500 Subject: [PATCH] cleanup --- .../chart-kpi/component-test.ts | 27 ------------------- .../chart-kpi-wrapper/component.ts | 4 --- 2 files changed, 31 deletions(-) diff --git a/app/institutions/dashboard/-components/chart-kpi-wrapper/chart-kpi/component-test.ts b/app/institutions/dashboard/-components/chart-kpi-wrapper/chart-kpi/component-test.ts index fd2f9bd1cf9..074e07d20c1 100644 --- a/app/institutions/dashboard/-components/chart-kpi-wrapper/chart-kpi/component-test.ts +++ b/app/institutions/dashboard/-components/chart-kpi-wrapper/chart-kpi/component-test.ts @@ -81,31 +81,4 @@ module('Integration | institutions | dashboard | -components | chart-kpi', hooks assert.dom('[data-test-expanded-total="0"]') .hasText('100000'); }); - - /** - * I need to determine if this is going to be a feature or not - test('it renders the without data correctly', async function(this: EnginesIntlTestContext, assert) { - const data = Object({ - total: 0, - title: 'This is the title', - icon: 'building', - }); - - this.set('data', data); - - - await render(hbs` - -`); - - assert.dom('[data-test-kpi-title]') - .hasText('This is the title'); - assert.dom('[data-test-kpi-data]') - .hasText('No data for institution found.'); - assert.dom('[data-test-kpi-icon]') - .hasAttribute('data-icon', 'building'); - }); - */ }); diff --git a/app/institutions/dashboard/-components/chart-kpi-wrapper/component.ts b/app/institutions/dashboard/-components/chart-kpi-wrapper/component.ts index 4bc74e2cdbe..e98adb5c807 100644 --- a/app/institutions/dashboard/-components/chart-kpi-wrapper/component.ts +++ b/app/institutions/dashboard/-components/chart-kpi-wrapper/component.ts @@ -11,10 +11,6 @@ import InstitutionDepartmentModel from 'ember-osf-web/models/institution-departm import InstitutionSummaryMetricModel from 'ember-osf-web/models/institution-summary-metric'; import SearchResultModel from 'ember-osf-web/models/search-result'; -/* -import InstitutionSummaryMetricModel from 'ember-osf-web/models/institution-summary-metric'; -*/ - export interface ChartDataModel { label: string; total: number;