Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fin Correlations #42

Open
OmarZaki96 opened this issue Jun 18, 2020 · 4 comments
Open

Fin Correlations #42

OmarZaki96 opened this issue Jun 18, 2020 · 4 comments

Comments

@OmarZaki96
Copy link

In FinCorrelations file, there are 2 issues:

  1. The height and width of the fin is calculated with (N+1) where N is number of tubes or rows; this is based on assuming the fin extends 0.5 spacing on both sides at the end.

This is not accurate as there is (N-1) spacings between the tubes, and assuming (2*0.5) additional spacing on the ends would make the total number is (N) not (N+1)

  1. WavyLouvered Fin correlations where Re is below 1000 has something wrong with it, there is discontinuity in the correlation before and after Re = 1000;
@abahman
Copy link
Contributor

abahman commented Jun 18, 2020

Hello Omar,
Thank you for your inquiry.
Can you please refer to the lines in the code.
Thank you

@OmarZaki96
Copy link
Author

OmarZaki96 commented Jun 18, 2020

For:

  1. Line 482, Taking N+1 spacing would depend on the staggered configuration, not necessarily (N+1)
    Height = P_t * (Ntubes_bank+1) #Height of heat exchanger [m] # assuming that fin extends 1/2 pt above/below last tube in bundle

  2. Lines 227, 228, 229
    Here is a plot of the correlation against Re
    f_plot

@abahman
Copy link
Contributor

abahman commented Jun 18, 2020

Omar,

1- Your justification makes sense. Can you PR after making all the changes?
2-Correlations always have limitations and that why sometimes you need to tune the model. This correlation was based on Wang et al. (1998) (https://doi.org/10.2514/2.6354). If you have any recent correlation that is more accurate, we will be happy to update the model.

Thank you

@OmarZaki96
Copy link
Author

OmarZaki96 commented Jun 18, 2020

Dr. Ammar,

Thanks for your fast response.

  1. I will do the necessary modifications, and PR with the changes.
  2. I don't think there is any recent correlation that can be used; however, I will try to work on this matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants