Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHEHX calculation #45

Open
xyx415 opened this issue May 23, 2022 · 1 comment
Open

PHEHX calculation #45

xyx415 opened this issue May 23, 2022 · 1 comment

Comments

@xyx415
Copy link

xyx415 commented May 23, 2022

Hello,

I tried to calculate with the PHEHX module and found out a potential copy-paste-error in the code:
line 1273: if Tin_h != Tout_c:
I think it should be "if Tin_h != Tout_h" (which checks if there is a glide)
Could you please check it? Thank you.

@abahman
Copy link
Contributor

abahman commented May 23, 2022

Hello @xyx415,
Thank you for your inquiry.
I agree with you about your suggestion. It seems it was a typo because the cold side analysis shows otherwise:

if Tin_c != Tout_c:

@davideziviani and @ibell
I just need to double-check and get a confirmation from you.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants