Pass uniforms to material constructor

[pjcozzi]

Low-hanging fruit...

• Part 1

Instead of writing

var polygon = new Polygon();
polygon.material = Material.fromType('Color');
polygon.material.uniforms.color = {
  red : 1.0,
  green : 1.0,
  blue : 0.0
  alpha : 1.0
};
primitives.add(polygon);

I want to be able to pass my overrides for the default uniform values to fromType

var polygon = new Polygon();
polygon.material = Material.fromType('Color', { 
  color : {
    red : 1.0,
    green : 1.0,
    blue : 0.0
    alpha : 1.0
  }
});
primitives.add(polygon);

So that I can construct polygon in one line without needing an instance:

primitives.add(new Polygon({
  material : Material.fromType('Color', { 
    color : {
      red : 1.0,
      green : 1.0,
      blue : 0.0
      alpha : 1.0
    }
  })
}));

• Part 2

(Part of #640). Replace Material.fromType with a new property in the object literal passed to the Material constructor.

new Material({
  type : 'Color',
  uniforms : {
    color : {
      red : 1.0,
      green : 1.0,
      blue : 0.0
      alpha : 1.0
     }
  }
});

Here type is used to indicate a known material type, as opposed to fabric which allows the entire Fabric JSON.

Add tests and update the Sandcastle examples.

[pjcozzi]

We can also consider basically swamping the current constructor and fromType (and renaming it to fromFabric).

[AnandDhoot]

Hi,
I would like to take up this issue. I have just downloaded and built the codebase on my machine.
Request your guidance on how to proceed on my first bug fix!
Thank you

[pjcozzi]

Thanks for the interest, @AnandDhoot. This issue is not very high priority right now. May I suggest you consider #1670?

[AnandDhoot]

Sure! Thanks for your reply.

[pjcozzi]

Insufficient priority.