Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE.md contains non-existent link to NVIDIA GameWorks Graphics Samples project #12123

Open
geekythoughts opened this issue Aug 14, 2024 · 1 comment

Comments

@geekythoughts
Copy link

What happened?

The project's LICENSE.md file references the "NVIDIA GameWorks Graphics Samples" under third party code however, the referenced GitHub project no longer exists: https://github.com/NVIDIAGameWorks/GraphicsSamples

Given the referenced NVIDIA GameWorks graphics sample project no longer exists, the reference to this project and license should get removed. The existence of this license may raise concerns from users, developers, and organizations for using Cesium.

There's also a reference to the NVIDIA GameWorkds Graphics Samples project is found in in the following (relative) source: packages/engine/Source/Shaders/FXAA3_11.glsl#L3
however, the license content differs than the license contents listed within LICENSE.md.

Is this NVIDIA samples project still used or perhaps moved to another repo and can this discrepancy get resolved?

Reproduction steps

  1. N/A - docuentation/license issue

...

Sandcastle example

No response

Environment

N/A - this is a documentation/licensing issue

@ggetz
Copy link
Contributor

ggetz commented Aug 15, 2024

Thanks for the report @geekythoughts. We'll look into how much, if any, came from that project and be sure to update the licensing accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants