Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gltf-pipeline as an npm module? #9614

Open
ptrgags opened this issue Jun 15, 2021 · 1 comment
Open

gltf-pipeline as an npm module? #9614

ptrgags opened this issue Jun 15, 2021 · 1 comment

Comments

@ptrgags
Copy link
Contributor

ptrgags commented Jun 15, 2021

@ebogo1 this is related to #9473

Today I updated gltf-pipeline, and noticed that the way we add the changes to Cesium are:

  1. run npm build-cesium in gltf-pipeline (Not sure everything this build step does, but it does take some Node.js code involving Buffer and adapts it for the browser according to @lilleyse )
  2. copy the output files into Source/ThirdParty/GltfPipeline
  3. commit the changes

Could this workflow be changed to use npm instead? e.g. release gltf-pipeline and then npm install in cesium?

@lilleyse
Copy link
Contributor

Not sure everything this build step does, but it does take some Node.js code involving Buffer and adapts it for the browser according to @lilleyse

It's actually simpler than that. It only packages certain files that are needed in CesiumJS and skips files that use Buffer and other Node concepts. So there's no browserify or rollup going on. That's a separate discussion: CesiumGS/gltf-pipeline#332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Notable backlog items
Development

No branches or pull requests

3 participants