Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encodeNormals and compressTextureCoordinates broken when performing AO #265

Closed
mramato opened this issue Apr 12, 2017 · 0 comments
Closed
Labels

Comments

@mramato
Copy link
Contributor

mramato commented Apr 12, 2017

If I enable encodeNormals or compressTextureCoordinates at the same time as passing aoOptions, I end up with two similar, but separate crashes:

Unhandled rejection TypeError: shader.replace is not a function
    at patchProgram (C:\Git\AnalyticalGraphicsInc\agi-swayze\node_modules\gltf-pipeline\lib\octEncodeNormals.js:153:21)
    at C:\Git\AnalyticalGraphicsInc\agi-swayze\node_modules\gltf-pipeline\lib\octEncodeNormals.js:94:21
    at C:\Git\AnalyticalGraphicsInc\agi-swayze\node_modules\gltf-pipeline\lib\getAccessorsForSemantic.js:31:33
    at Promise._execute (C:\Git\AnalyticalGraphicsInc\agi-swayze\node_modules\bluebird\js\release\debuggability.js:300:9)
Unhandled rejection TypeError: shader.replace is not a function
    at patchProgram (C:\Git\AnalyticalGraphicsInc\agi-swayze\node_modules\gltf-pipeline\lib\compressTextureCoordinates.js:152:21)
    at C:\Git\AnalyticalGraphicsInc\agi-swayze\node_modules\gltf-pipeline\lib\compressTextureCoordinates.js:90:21
    at C:\Git\AnalyticalGraphicsInc\agi-swayze\node_modules\gltf-pipeline\lib\getAccessorsForSemantic.js:31:33
    at Promise._execute (C:\Git\AnalyticalGraphicsInc\agi-swayze\node_modules\bluebird\js\release\debuggability.js:300:9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant