diff --git a/packages/discv5/src/metrics.ts b/packages/discv5/src/metrics.ts index f3d82373..bd143142 100644 --- a/packages/discv5/src/metrics.ts +++ b/packages/discv5/src/metrics.ts @@ -1,33 +1,32 @@ export interface MetricsRegister { - gauge(config: GaugeConfig): IGauge; + gauge(config: GaugeConfig): Gauge; } -type GaugeConfig = { +type GaugeConfig = { name: string; help: string; - labelNames?: T[] | readonly T[]; -}; +} & (NoLabels extends Labels ? { labelNames?: never } : { labelNames: [LabelKeys, ...LabelKeys[]] }); -type Labels = Partial>; -interface IGauge { - inc(value?: number): void; - inc(labels: Labels, value?: number): void; - set(value: number): void; - set(labels: Labels, value: number): void; - collect(): void; +type NoLabels = Record; +type LabelsGeneric = Record; +type LabelKeys = Extract; +interface Gauge { + inc: NoLabels extends Labels ? (value?: number) => void : (labels: Labels, value?: number) => void; + set: NoLabels extends Labels ? (value: number) => void : (labels: Labels, value: number) => void; + collect?(): void; } export interface IDiscv5Metrics { - kadTableSize: IGauge; - activeSessionCount: IGauge; - connectedPeerCount: IGauge; - lookupCount: IGauge; + kadTableSize: Gauge; + activeSessionCount: Gauge; + connectedPeerCount: Gauge; + lookupCount: Gauge; - sentMessageCount: IGauge<"type">; - rcvdMessageCount: IGauge<"type">; + sentMessageCount: Gauge<{ type: string }>; + rcvdMessageCount: Gauge<{ type: string }>; - rateLimitHitIP: IGauge; - rateLimitHitTotal: IGauge; + rateLimitHitIP: Gauge; + rateLimitHitTotal: Gauge; } export type Metrics = ReturnType; @@ -59,13 +58,13 @@ export function createDiscv5Metrics(register: MetricsRegister) { help: "Count of the discv5 connected peers", }), /** Total number messages sent by message type */ - sentMessageCount: register.gauge<"type">({ + sentMessageCount: register.gauge<{ type: string }>({ name: "discv5_sent_message_count", help: "Count of the discv5 messages sent by message type", labelNames: ["type"], }), /** Total number messages received by message type */ - rcvdMessageCount: register.gauge<"type">({ + rcvdMessageCount: register.gauge<{ type: string }>({ name: "discv5_rcvd_message_count", help: "Count of the discv5 messages received by message type", labelNames: ["type"],