Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a more robust check for rinfo.family #176

Closed
dadepo opened this issue May 11, 2022 · 0 comments · Fixed by #178
Closed

Have a more robust check for rinfo.family #176

dadepo opened this issue May 11, 2022 · 0 comments · Fixed by #178

Comments

@dadepo
Copy link
Contributor

dadepo commented May 11, 2022

As reported on discord here in node version 18 on MacOS, the value of rinfo.family was an integer type 4.

Even though the documentation here states the value should be of type string with value being either 'ipv4' or 'ipv6'. Clearly this is not the case as I was also able to confirm the issue.

This PR makes the check for rinfo.family more robust such that it does not fail in this observed mismatch between documentation and behaviour of node/os version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant