Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure blocks are finalized on time near head #1481

Closed
noot opened this issue Mar 19, 2021 · 4 comments · Fixed by #1499 or #1519
Closed

ensure blocks are finalized on time near head #1481

noot opened this issue Mar 19, 2021 · 4 comments · Fixed by #1499 or #1519
Assignees
@noot

Comments

@noot
Copy link
Contributor

noot commented Mar 19, 2021 •
edited
Loading

Task summary

  • when syncing near the head of kusama or polkadot, we will need to ensure blocks are finalized in a timely manner
  • this requires receiving and processing finalization messages on the grandpa substream, which currently doesn't seem to be happening
  • fix this and ensure blocks are marked finalized
@noot noot self-assigned this Mar 24, 2021
@noot noot mentioned this issue Mar 31, 2021
Merged
@noot noot closed this as completed in #1499 Apr 5, 2021
@noot noot mentioned this issue Apr 6, 2021
Merged
@github-actions
Copy link

github-actions bot commented Apr 9, 2021

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@noot noot reopened this Apr 12, 2021
@noot
Copy link
Contributor Author

noot commented Apr 12, 2021

need to update grandpa messages to match spec and handle accordingly

@noot noot mentioned this issue Apr 13, 2021
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

1 similar comment
@github-actions
Copy link

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noot noot

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dutterbutter @noot