Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate random name when --name flag is not used #1496

Closed
edwardmack opened this issue Mar 30, 2021 · 3 comments · Fixed by #1506
Closed

Generate random name when --name flag is not used #1496

edwardmack opened this issue Mar 30, 2021 · 3 comments · Fixed by #1506
Assignees

Comments

@edwardmack
Copy link
Contributor

Describe the bug

  • Currently when starting the gossamer node, the node's name defaults to "Polkadot" if the --name flag is not used.

Expected Behavior

  • When the --name flag is not used the node should generate a random name (so that the node can be uniquely identified). The ParityTech Polkadot nodes generate a name by compining two random words followed by a 4 digit number. For example: cuddly-rake-4006

Current Behavior

  • Currently Gossamer node uses default name 'Polkadot' if the '--name' flag is not used.

Possible Solution

  • Add function to generate random name when --name flag is not used.

To Reproduce

Steps to reproduce the behavior:

  1. Start gossamer node without name flag.
  2. Observe name defaults to "Polkadot"

Log output

Log Output
INFO[03-30|14:15:44] 🕸️ initializing node services...    pkg=dot name=Polkadot id=polkadot basepath=/home/emack/.gossamer/polkadot caller=node.go:180

Specification

  • go version:
  • gossamer version: 0.3.2
  • gossamer commit tag:
  • gossamer commit hash:
  • operating system:
  • additional links:
@github-actions
Copy link

github-actions bot commented Apr 9, 2021

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

1 similar comment
@github-actions
Copy link

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants