Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate scale package into internal packages #1621

Closed
timwu20 opened this issue Jun 3, 2021 · 2 comments
Closed

Integrate scale package into internal packages #1621

timwu20 opened this issue Jun 3, 2021 · 2 comments
Assignees
Labels
Epic Issue used to track development status of a complex feature, aggregates several issues

Comments

@timwu20
Copy link
Contributor

timwu20 commented Jun 3, 2021

Task summary

  • Evaluate use of custom Encode()/Decode() functionality on struct types. Should all be covered by new Marshal()/Unmarshal() functionality. Remove the Encode()/Decode() receiver functions.
  • Change all occurrences of Encode()/Decode() to use new Marshal()/Unmarshal() interface.
  • Implement VaryingDataType pattern for existing structs that decode SCALE/Rust enums
  • Implement Result pattern for existing use case in lib/runtime/wasmer/imports.go
  • Ensure that existing encoded data stored in DB is successfully decoded

Specification reference

Other information and links

@jimjbrettj
Copy link
Contributor

jimjbrettj commented Aug 9, 2021

  • lib/babe
  • lib/common
  • lib/genesis
  • lib/grandpa
  • lib/runtime
  • lib/transaction
  • lib/trie
  • dot/core
  • dot/digest WIP
  • dot/network WIP
  • dot/rpc
  • dot/state
  • dot/sync
  • dot/types WIP

@dutterbutter dutterbutter added the Epic Issue used to track development status of a complex feature, aggregates several issues label Aug 26, 2021
@noot
Copy link
Contributor

noot commented Mar 17, 2022

closing as this has been completed

@noot noot closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Issue used to track development status of a complex feature, aggregates several issues
Projects
None yet
Development

No branches or pull requests

4 participants