Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update *types.Body to be of type []types.Extrinsic #1775

Closed
noot opened this issue Sep 1, 2021 · 1 comment · Fixed by #1807
Closed

update *types.Body to be of type []types.Extrinsic #1775

noot opened this issue Sep 1, 2021 · 1 comment · Fixed by #1807

Comments

@noot
Copy link
Contributor

noot commented Sep 1, 2021 •
edited by arijitAD
Loading

Task summary

  • currently the block body is of type []byte, and we assume what is placed in it is a SCALE encoded array of extrinsics: ie []types.Extrinsic
  • however, this can cause confusion, and the type should be what it really is, which is []types.Extrinsic

Ref: https://substrate.dev/docs/en/knowledgebase/advanced/codec
@noot noot added p2 labels Sep 1, 2021
@arijitAD arijitAD mentioned this issue Sep 27, 2021
Merged
4 tasks
@noot noot closed this as completed in #1807 Oct 5, 2021
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This issue has been resolved in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dot/types): *types.Body to be of type []types.Extrinsic kishansagathiya/gossamer
2 participants
@dutterbutter @noot