Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: consolidate *config/Config and *dot/Config #1848

Open
noot opened this issue Oct 8, 2021 · 0 comments
Open

config: consolidate *config/Config and *dot/Config #1848

noot opened this issue Oct 8, 2021 · 0 comments
Labels
C-simple Minor changes changes, no additional research needed. Good first issue/review.

Comments

@noot
Copy link
Contributor

noot commented Oct 8, 2021

Task summary

  • we currently have two configuration types defined in gossamer, first is *config/config.go which is used to unmarshal the toml config file, and the second is *dot/Config which is used to create the internal node services
  • consolidate these two types into 1, this will require toml custom unmarshalling for some fields as the types don't match, eg LogLvl, Pruning, DiscoveryInterval
@kanishkatn kanishkatn changed the title config: consolidate *dot/config/toml/Config and *dot/Config config: consolidate *config/Config and *dot/Config May 3, 2023
@P1sar P1sar removed dot labels Jan 15, 2024
@LernaJ LernaJ added the C-simple Minor changes changes, no additional research needed. Good first issue/review. label Jul 9, 2024
@LernaJ LernaJ added this to the Production Full Node milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-simple Minor changes changes, no additional research needed. Good first issue/review.
Projects
None yet
Development

No branches or pull requests

4 participants