Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate codebase for memory problems #1973

Open
5 of 11 tasks
qdm12 opened this issue Nov 3, 2021 · 1 comment
Open
5 of 11 tasks

Investigate codebase for memory problems #1973

qdm12 opened this issue Nov 3, 2021 · 1 comment
Labels
Epic Issue used to track development status of a complex feature, aggregates several issues

Comments

@qdm12
Copy link
Contributor

qdm12 commented Nov 3, 2021

This is more of low hanging fruits that can be worth checking/fixing before investing more time in profiling and metrics, to fix the current memory issue we have (2021-11-03).

  • Check usage of bytes.Buffer (local branch)
  • Check usage of pools
  • Check usage of copy
  • Check buffered channels (using regex make\(chan .+, [1-9].+\))
  • Check DeepCopy functions (search for deepcopy without case sensitivity)
  • Check usage of sizedBufferPool - found a problem, fixed in fix(dot/network): fix memory allocations with sizedBufferPool #1963, although not a reason for OOM
  • Check for arrays returned (copy, it's not a slice), use regex \[[a-zA-Z0-9]+\](byte|int|uint|uint32|uint64|int32|int64|string)+?
  • Check packages
    • dot/network
    • lib/trie
    • dot/sync
@danforbes danforbes added the p1 label Nov 29, 2021
@danforbes danforbes added the Epic Issue used to track development status of a complex feature, aggregates several issues label Jan 24, 2022
@danforbes danforbes removed the go label Mar 15, 2022
@qdm12
Copy link
Contributor Author

qdm12 commented Dec 7, 2022

The current state as of today is:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Issue used to track development status of a complex feature, aggregates several issues
Projects
None yet
Development

No branches or pull requests

3 participants