tests/utils: make helping functions not test aware #2389
Assignees
Comments
qdm12
changed the title
qdm12
added a commit
that referenced
this issue
Jun 10, 2022
- make RPC helper functions not test aware - `waitForNode` context based function - Use `t.TempDir()` for nodes base paths - Add `GenerateGenesisAuths` helper function - Remove global variables - `GenesisDefault`, `GenesisDev`, `GenesisTwoAuthsSecondaryVRF0_9_10` - framework variable - configuration variables - `HOSTNAME` variable - `maxTries` in stress tests - `testTimeout` in stress tests - Write node configurations to `t.TempDir()` per test - Remove `DecodeRPC_NT` function - Split `tests/utils` package - `tests/utils/rpc` package - `tests/utils/websocket` package - `tests/utils/config` package - Rework start and stop of nodes - Init nodes in parallel - Remove unneeded logs - Log when node is ready - Prefix writer with node string for multiple nodes - Wait for nodes after starting all nodes - Add test writer using `t.Logf` - Refactor `getResponse` - not test aware - get passed target interface - push test assertion/skip to actual test - Add helper `retry.UntilNoError` and `retry.UntilOK` functions - Use in `compareBlocksByNumber` - Use in `waitForNode` - Change `GetBlockHash` to not retry RPC - Remove `PostWithRetry` - Replace `compareFinalizedHeadsWithRetry` with `retry.UntilOK` - Refactor and fix `TestSystemRPC` - Add empty skipped tests for missing cases - Split each subtest individually - Keep on retrying until main context is canceled - Fix `networkState` test case - Assert more fields - Fix #2161 and #807 - Refactor and fix `TestSync_SingleBlockProducer` - Refactor and make faster `TestAuthorSubmitExtrinsic` - Configure nodes using TOML Go struct only - Pass `--no-telemetry` as flag since it's not in TOML config - `dot`: remove `exportConfig` and `TestExportConfig` - `dot`: remove `ExportTomlConfig` and its test - Install NPM dependencies from Go code for polkdaot JS test - Remove `websocket` package - Use `Decode` from rpc package instead - Add fields to RPC server response struct - Do not use `reflect` - Add `fetchWithTimeout` helper function - Change test cases slices to individual subtests - Add `t.SkipNow()` to parent tests where all subtests are skipped - Make `TestChainRPC` event driven and increase testing depth - Add a few `TODO`s to increase testing depth - Run each query call in parallel - Refactor `TestChainSubscriptionRPC` - Refactor websocket code - Assert things and increase test depth - Graceful shutdown of websocket - Merge stable workflow in rpc workflow - Use Go to implement `integration-test-all.sh` directly in single 'stable' test - The test is fast and only does RPC calls, it should be part of the RPC workflow - Remove stable workflow from Makefile, github workflows directory and document - Log out command, logs and configuration file content on runtime error - Fixes directly related issues #2389, #2390, #2391 - Fixes flaky tests issues #807, #2161, #2165, #2167 Co-authored-by: Timothy Wu <timwu20@gmail.com>
|
Done in 6220402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Task summary
Several helping functions are test aware, and get passed a
t *testing.T.These should all be changed to only return an error and not fail the test.
This would allow for a graceful shutdown of each test, and to separate responsabilities.
Created from #2326
The text was updated successfully, but these errors were encountered: