Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read runtime version from code wasm custom sections #2758

Open
qdm12 opened this issue Aug 17, 2022 · 1 comment
Open

read runtime version from code wasm custom sections #2758

qdm12 opened this issue Aug 17, 2022 · 1 comment

Comments

@qdm12
Copy link
Contributor

qdm12 commented Aug 17, 2022

For newer runtimes, the runtime version can now be obtained from the WASM custom sections from the wasm code, and there is no longer a need to instantiate the full runtime to check its version.

For context:

Note reading the runtime version by instantiating it and calling Core_version still need to be supported for older runtimes.

So the process should be:

  1. try to find versions from the wasm custom section
  2. fallback to instantiating + calling Core_version on the instance
@danforbes danforbes changed the title Enhancement: read runtime version from code wasm custom sections read runtime version from code wasm custom sections Aug 22, 2022
@timwu20
Copy link
Contributor

timwu20 commented Nov 29, 2023

This is an optimization that isn't required for any milestone at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants