Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MDNS implementation github.com/libp2p/go-libp2p/p2p/discovery/mdns #2993

Closed
qdm12 opened this issue Dec 6, 2022 · 1 comment
Closed
Assignees
Labels
P-low this is mostly nice to have. S-network issues related to the dot/network package.

Comments

@qdm12
Copy link
Contributor

qdm12 commented Dec 6, 2022

Our current implementation (before PR #2794) is based on https://github.com/libp2p/go-libp2p/tree/644dadc30bcc712ea13ad730f50b5e8ec1b949f2/p2p/discovery/mdns_legacy

Unfortunately, mdns_legacy got removed in libp2p/go-libp2p@707100a so all releases since v0.21.0 do not have it anymore. The only alternative since is https://github.com/libp2p/go-libp2p/blob/4c74181d0dada0b4d600885285b96afee74e223d/p2p/discovery/mdns/mdns.go

Unfortunately again, this new mdns implementation will not work with our RPC test TestStableNetworkRPC with 3 nodes.

MODE=rpc go test -run ^TestStableNetworkRPC$ github.com/ChainSafe/gossamer/tests/rpc -v

This issue may be related to libp2p/go-libp2p#1333 (or not).

After #2794 is merged, we should try upgrading to the new mdns package https://github.com/libp2p/go-libp2p/blob/4c74181d0dada0b4d600885285b96afee74e223d/p2p/discovery/mdns/mdns.go and remove the code in internal/mdns (based on mdns_legacy, in order to be able to upgrade libp2p dependencies).

@timwu20
Copy link
Contributor

timwu20 commented Nov 30, 2023

We should probably revisit this at some point since we're using a fork of the old libp2p/go-libp2p/p2p/discovery/mdns_legacy.

@P1sar P1sar closed this as completed Feb 23, 2024
@P1sar P1sar self-assigned this Feb 23, 2024
@P1sar P1sar added S-network issues related to the dot/network package. P-low this is mostly nice to have. labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-low this is mostly nice to have. S-network issues related to the dot/network package.
Projects
None yet
Development

No branches or pull requests

4 participants