Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate scale custom encoding, clean up custom type encoding methods #611

Closed
noot opened this issue Feb 12, 2020 · 1 comment
Closed
Assignees

Comments

@noot
Copy link
Contributor

noot commented Feb 12, 2020

since SCALE now has EncodeCustom and DecodeCustom functions to check if a type has a custom encoding function, we can clean up instances of types that have types within them that can be custom encoded.

SCALE may also need to be updated to integrate the Custom functions within EncodeTuple, EncodeArray, etc. same for Decode. additionally all custom functions should have the function sig func (ms *MyStruct) Decode(r io. Reader) error

including but not limited to usages of: p2p message types, babe types, optional types

@Noc2
Copy link

Noc2 commented Apr 19, 2021

just fyi: https://github.com/itering/scale.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants