Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: improve gossip algorithm by ensuring duplicate messages aren't sent to peers #738

Closed
noot opened this issue Apr 1, 2020 · 3 comments
Assignees

Comments

@noot
Copy link
Contributor

noot commented Apr 1, 2020

currently, the gossip algorithm is flooding, so sending the message to every peer except the one that it was received from. this should be improved as to reduce network bandwidth. one method of improving the gossip mechanism is to choose a number of peers to send the message to, say n, then randomly select n peers out of our total peers. there are also other algorithms that could be used, will need some research and exploration. could make n configurable for now to determine best (ie. trade-off between bandwidth and propagation) value

@noot noot assigned noot and unassigned noot Apr 3, 2020
@noot noot removed their assignment May 3, 2020
@p4u
Copy link

p4u commented May 11, 2020

Just in case this might help to get some ideas.

https://github.com/vocdoni/docs/wiki/SubPub-Mesh-routing

@ryanchristo ryanchristo removed their assignment Jun 11, 2020
@noot noot self-assigned this Jun 23, 2020
@noot noot removed their assignment Nov 12, 2020
@noot
Copy link
Contributor Author

noot commented Nov 17, 2020

this can be "pivoted" to be the gossiping of messages sent via notifications protocols

@noot
Copy link
Contributor Author

noot commented Feb 18, 2021

also see spec 4.1.7.3: "Polkadot Host
implementers should implement a mechanism which only sends a transaction once to each peer and
avoids sending duplicates. Sending duplicate transactions might result in undefined consequences
such as being blocked for bad behavior by peers."

we need to ensure we aren't sending the duplicate messages to peers.

@noot noot self-assigned this Feb 25, 2021
@noot noot removed their assignment Mar 4, 2021
@dutterbutter dutterbutter added p2 and removed p3 labels Mar 18, 2021
@noot noot changed the title network: improve gossip algorithm network: improve gossip algorithm by ensuring duplicate messages aren't sent to peers Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants